Conversation
balloob
previously approved these changes
Mar 28, 2022
balloob
reviewed
Mar 28, 2022
| data[field.name] = [0, 0, 0]; | ||
| } else if ("color_temp" in selector) { | ||
| data[field.name] = selector.color_temp.min_mireds ?? 153; | ||
| } |
Member
There was a problem hiding this comment.
Let's make sure we notice it when we're adding new selectors.
Suggested change
| } | |
| } else { | |
| throw new Error("Selector not supported in initial form data"); | |
| } |
Contributor
Author
There was a problem hiding this comment.
We haven't added all of them. Device, Entity, area, etc. SHould we just do empty string?
zsarnett
changed the title
balloob
reviewed
Mar 28, 2022
Comment on lines
+39
to
+43
| if (selector.device.multiple) { | ||
| data[field.name] = []; | ||
| } else { | ||
| data[field.name] = ""; | ||
| } |
Member
There was a problem hiding this comment.
Slightly more readable
Suggested change
| if (selector.device.multiple) { | |
| data[field.name] = []; | |
| } else { | |
| data[field.name] = ""; | |
| } | |
| data[field.name] = selector.device.multiple ? [] : ""; |
balloob
previously approved these changes
Mar 28, 2022
zsarnett
changed the title
balloob
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: